On Tue, Feb 26, 2008 at 10:22:21PM -0500, Stephen Talley wrote:
> http://cr.opensolaris.org/~talley/6667461_6667462_6667464/
Everything else in the gate patches up man pages with a sed script. Is
there a reason you didn't do it the same way?
I'll make the same comment as I did for Nico -- ident lines are comments in
all files that aren't run through a processor which understand "#ident" as
a pragma. Thus shell scripts and makefiles shouldn't have "#ident", but
"# ident", just like any other comment.
fetchmail/Makefile.sfw:
- line 36: This isn't used. (Same line in the other makefiles.)
- line 44: What's needed out of /usr/sfw/lib that doesn't come from this
consolidation (and hence the proto-area version should be used)?
(Same question for the other makefiles.)
- line 88: why are you constructing fetchmailconf in the makefile? Why
not just create the file and install it? Or, since you're doing
nothing but execing the python file, why not just put the python file
in /usr/bin? Is that to prevent the .pyc file from getting created in
/usr/bin?
mutt/Makefile.sfw:
- line 128: I'm not terribly happy with this, but I don't know whether
our gettext supports locale aliasing. Anyone know? Should we file an
RFE if it doesn't?
- line 129: This should probably be /etc/mutt.
- line 131: Do you really need this on top of line 130?
mutt/stubman.sh:
- line 34: I don't think this manpage needs to be run through eqn. And
not tbl as it stands, though it should have the standard table in an
ATTRIBUTES section with the Interface Stability entry.
slang/Makefile.sfw:
- line 82: likely sysconfdir should be under /etc here, too.
- line 115: likely not useful for the 64-bit target.
- line 132: I think you could just do "make install-elf", no?
SUNWfetchmail/prototype_com:
- line 55: We don't typically ship .pyo files.
Do make sure that the .pyc file has a newer timestamp than the .py file;
otherwise it'll get re-created at runtime, and pkgchk will fail.
SUNWmutt/protoype_com:
- line 120ff: Is there a reason that message files are going in
/usr/share, rather than /usr/lib?
SUNWprocmail/depend:
- Is there a reason you're not using the common depend file here?
All of these components are at least partly GPLv2. Typically legal
requires that we put a disclaimer at the top of the copyright file (or
something similar, but that's how we've been interpreting that requirement)
that says that we're distributing under v2 *only*, and no later versions.
Were you not asked to do something like this?
Danek
