On Thu, Feb 28, 2008 at 10:20:35PM -0500, Stephen Talley wrote:
> http://cr.opensolaris.org/~talley/6667461_6667462_6667464.inc.1.2/
> > > > mutt/Makefile.sfw:
> > > >
> > > > o line 129: This should probably be /etc/mutt.
> > >
> > > I wavered a bit on this, but ultimately chose /usr/share/mutt/etc
> > > in part to avoid conflicts with the system's /etc/mime.types. But
> > > I can be persuaded here.
> >
> > No need to put it in /etc directly; /etc/mutt would be appropriate. It
> > should go under /etc because /usr is not always mounted read-write, so
> > it's inappropriate to put possibly editable configuration files there.
>
> Okay, agreed.
Except that I'm not sure we should be shipping any configuration files that
are loaded by default. Either for mutt or for slang. I think it's fine to
have sample rc files in /usr/share/wherever, which can then be copied into
/etc, but I don't see the point in shipping some random config by default.
> > > > All of these components are at least partly GPLv2. Typically legal
> > > > requires that we put a disclaimer at the top of the copyright file
> > > > (or something similar, but that's how we've been interpreting that
> > > > requirement) that says that we're distributing under v2 *only*, and
> > > > no later versions. Were you not asked to do something like this?
>
> My recollection is that the only instructions from the OSR tool w.r.t.
> the copyright file was that it had to reflect the license(s) from the
> product. No mention, AFAICR, of the aforementioned ammendment.
Yeah, like Mike said, with the new, speedy approval process, they may have
stopped asking that. It's not clear if it's no longer a requirement or
not. Oh joy.
Further comments on the review:
fetchmail/Makefile.sfw:
- line 70: I see from the package prototype that you're making
/usr/bin/fetchmailconf a symlink to the .py file in vendor-packages.
You should construct the proto area to match the package. Is
fetchmailconf.py ever imported by anything, or is it intended only to
be executed? If the latter, it shouldn't be in vendor-packages at all.
SUNWfetchmail/Makefile:
- line 30: If you're going to start pulling prototype_{i386,sparc} from
common_files, then you should probably do this for the rest of the
packages, too. If that doesn't appeal, do it the way everyone else
does.
SUNWmuttr/Makefile:
- line 36: Please just keep a separate copy in this directory (if you
really want a SUNWmutt, anyway).
SUNWmuttr/prototype_com:
- line 41: You made a change, but didn't make it everywhere. This and
the Makefile say renamenew, but the actual files and the pkginfo say
renameold. Pick one.
tools/Makefile:
- Why is this new?
tools/sunman.sh:
- line 33: No need to put $PATH in $PATH.
- line 66: How many platforms is this script goin to run on?
- line 102: "Amend".
Danek
