--- /dev/null   Fri Nov 16 16:27:27 2007
+++ new/usr/src/cmd/apache2-modules/Makefile.sfw        Fri Nov 16 16:27:27 2007
+all:
+       echo "Dummy target use install to make and install."

Why is all a dummy target?

+install: installfcgid installjk installsecurity
the scripts are largely the same and could just be functions in one 
install-modules script.


+install32: make32
+       /usr/bin/ksh93 ./install-fcgid -b 32
+
+install64: make64
+       /usr/bin/ksh93 ./install-fcgid -b 64

I think the convention is to have 2 scripts: install-$component and 
install-$component-64.

+
+installfcgid:
+       /usr/ccs/bin/make -f Makefile.sfw.fcgid install
+
+installjk:
+       /usr/ccs/bin/make -f Makefile.sfw.jk install
+
+installsecurity:
+       /usr/ccs/bin/make -f Makefile.sfw.security install
+
+clean: cleanfcgid cleanjk cleansecurity
+
+cleanfcgid:
+       /usr/ccs/bin/make -f Makefile.sfw.fcgid clean
+
+cleanjk:
+       /usr/ccs/bin/make -f Makefile.sfw.jk clean
+
+cleansecurity:
+       /usr/ccs/bin/make -f Makefile.sfw.security clean

Rather than having separate-but-mostly-the-same Makefiles, you could probably 
consolidate these into a single Makefile.sfw with different targets. I didn't 
see any other examples in the codebase that split up Makefile.sfw into 
individual makefiles.

+DESC="Tomcat Connector plugin for Apache HTTP Server Version 2.2"
For consistency, this should probably be 'Apache Web Server V2.2'
 
 
This message posted from opensolaris.org

Reply via email to