[Arvind Srinivasan:]
| --- /dev/null Fri Nov 16 16:27:27 2007
| +++ new/usr/src/cmd/apache2-modules/Makefile.sfw Fri Nov 16 16:27:27 2007
| +all:
| + echo "Dummy target use install to make and install."
|
| Why is all a dummy target?
I am using apxs to compile all the source files. apxs compiles all the
files with out checking if the .o files exist or not.
Since splitting the build and install did not give me any advantage
(since recompilation takes place any way) I moved them to a single
target. (and it helps to simplify things a little bit as I can use the
same directory for both 32 and 64 bit building, and the install script
is also simple.)
| +install: installfcgid installjk installsecurity
| the scripts are largely the same and could just be functions in one
install-modules script.
|
|
| +install32: make32
| + /usr/bin/ksh93 ./install-fcgid -b 32
| +
| +install64: make64
| + /usr/bin/ksh93 ./install-fcgid -b 64
|
| I think the convention is to have 2 scripts: install-$component and
install-$component-64.
As mentioned above, since apxs is used, the building process is slightly
unconventional. :) and it was simpler to go with a single install
script. (Only a single variable gets changed 32 and 64 bit install.)
(More explanation at the end.)
| +
| +installfcgid:
| + /usr/ccs/bin/make -f Makefile.sfw.fcgid install
| +
| +installjk:
| + /usr/ccs/bin/make -f Makefile.sfw.jk install
| +
| +installsecurity:
| + /usr/ccs/bin/make -f Makefile.sfw.security install
| +
| +clean: cleanfcgid cleanjk cleansecurity
| +
| +cleanfcgid:
| + /usr/ccs/bin/make -f Makefile.sfw.fcgid clean
| +
| +cleanjk:
| + /usr/ccs/bin/make -f Makefile.sfw.jk clean
| +
| +cleansecurity:
| + /usr/ccs/bin/make -f Makefile.sfw.security clean
|
| Rather than having separate-but-mostly-the-same Makefiles, you could probably
consolidate
| these into a single Makefile.sfw with different targets. I didn't see any
other examples
| in the codebase that split up Makefile.sfw into individual makefiles.
the install-* are also almost the same, I kept them separate so that it
is easier to manage. ( The split is Makefile/Install-XXX where XXX is
component rather than the bitness specification. I went for this since
there is a greater degree of separation between what needs to be done
for different components than what needs to be done differently for
different bit sizes.)
|
| +DESC="Tomcat Connector plugin for Apache HTTP Server Version 2.2"
| For consistency, this should probably be 'Apache Web Server V2.2'
updated.
rahul
--
1. e4 _
