Updating the webrev with the recommendations. (Available below)
http://cr.opensolaris.org/~vrthra/apache-modules/
Salient points:
1) The modules are moved under usr/cmd/apache2/modules
2) Only a single make file Makefile.sfw that builds all modules
Uses apxs-<component> to capture the different arguments to apxs
and preparations to the extracted dir if any to run apxs.
3) 'build all' and install steps separated. Now build creates the modules in
their specified directories and install moves it to proto.
4) A single install-module to trasport the components to their proto home
> I'm going to echo Arvind's note about having separate targets for each
> module in the top-level Makefile.
> ...
>
> and put each module in its own subdirectory.
-- done
> I'm confused by your explanation of the dummy "all" target. Nightly by
> default doesn't invoke "all", it just makes install, so you wouldn't
> normally be building the objects twice. But shouldn't a hand-run "make
> all" build the files without putting them in $PROTO, even if a later
> invocation of "make install" would rebuild them?
-- done this way now.
...(arvind answered on mod_perl)
> Makefile.sfw.fcgid:
>
> - line 30: Please use "ISAINFO:sh = isainfo -n" here instead; it stands
> out better as a shell-out command
-- done using $(MACH64) now
> - line 67: Why do you need gtar for this? Is tar xopf not enough?
-- now uses $(TAR) -- why is it better to use tar ?
> Makefile.sfw.jk:
> - lines 37, 50: Why do you need to set LD_LIBRARY_PATH? Does apxs
> require a library here, or does it run something it builds?
-- updated to remove LD_LIBRARY_PATH
> install-fcgid:
> - line 1: you run this with ksh93, but the shebang says ksh. Please pick
> one and use it in both places.
-- done uses env consistently.
> - the other two install-* scripts are remarkably similar; perhaps the
> code could be shared?
-- done only one install script now.
> Wapch22m-fcgid/copyright:
> - I believe you'll need the few lines of "v2-only" disclaimer that we're
> putting in the rest of the copyright files, unless these already don't
> have the "(at your option) any later version" clause.
--done
> SUNWapch22m-fcgid/depend:
>
> - I don't think there's any reason to depend on
> SUNWapch22r.
--done
This message posted from opensolaris.org
