On Nov 28, 2007 7:22 PM, Petr Sumbera <Petr.Sumbera at sun.com> wrote: > Hi Shiv, > > I think you might be first one who is looking for a sponsor for SFW at > all. I can eventually try to volunteer to help you. > > But first you will need to ask in this alias for code review. >
Review has been done (multiple rounds) on sfwnv list even before ARC submission happened. I will let Mike confirm this. > As I already saw your webrev I can note that your wx comments should > contain only CR and synopsis (other notes you have there should go to > bug database - so keep them separately). > SFW is currently just a tarball. No hg or svn repository exists. The webrev I provided is for reference and is not really usable for a direct commit ! > Also I noted that you added some copyright message mentioning your name. > I think it's not possible (as far as I know). Credit to you should be > given via putback comment in a following way: > > <CR> <synopsis> > Contributed by <your name> <email> > This I included only after the code review comment. I am not able to locate the specific mail. Not including also is ok with me. > The only problem is that putback notification for sfwnv gate (unlike ON > gate) is not sent to OpenSolaris. > > But again I might be wrong so I have CCed Mike who will for sure know > more. Anyway I can forward notification to this list so you will see > when we are done :-) > ok. -Shiv
