Thanks for the comments, Dermot. On Wed, 2007-08-08 at 16:39 +0100, Dermot.McCluskey at Sun.COM wrote: > A few comments: > > usr/src/pkgdefs/SUNWlexpt/prototype_com > - don't you still need to have definitions for /usr/sfw & /usr/sfw/lib ?
I have them in prototype_sparc and prototype_i386, but you're right, they should be in prototype_com. I'm moving those lines. > usr/src/pkgdefs/SUNWsfwhea/prototype_com > - I'm sure David will be pointing out that you should keep the > file list in alphabetical order It is alphabetical, but 'd' lines come first, then 'f' lines and 's' lines last. I was just following the existing order. > - in fact, why not move the .h files to SUNWlexpt. This is what we're > usually doing now, along with sfinf, sfman, etc. I always thought it was a Solaris packaging requirement that development files must be packaged separately. While I don't like big aggregate packages like SUNWsfwhea, I think the headers should be in SUNWlexpt-devel, like in SUNWlxml-devel or SUNWpostgr-devel and not in SUNWlexpt. What do people think about this? > is the pkg's depend file in sync with the COPYING file from the > source tarball? hmm? > your bug says libexpat 2.0.0, but you're actually integrating 2.0.1 It should really say at least 2.0.0. I'll update it. Thanks, Laca
