Hi,
> idzebra has been updated with changes for the last round of comments
> from Jim Walker. Could someone in addition to Jim please look at it
> this time so I can hopefully get my two reviewers?
>
> The webrev is at:
>
> http://cr.opensolaris.org/~andrejm/idzebra/
usr/src/Targetdirs:
usr/src/pkgdefs/SUNWidzebra/Makefile:
usr/src/pkgdefs/SUNWidzebra/copyright:
That file does not seem to have any differences. Either there should be
something, or it should not be in the webrev.
usr/src/cmd/Makefile:
usr/src/pkgdefs/Makefile:
You seem to be only adding perl510. Probably it's just unsynced
workspace. But again, if you are not adding anything here, Makefile
should not be in webrev.
usr/src/cmd/idzebra/Makefile.sfw:
I wonder, why theese two are enclosed in brackets
103 + ($(RM) -r $(ROOTLIB64)/idzebra*/modules)
104 + ($(MV) $(ROOTBIN)/idzebra-config-* $(ROOTBIN)/idzebra-config)
usr/src/pkgdefs/SUNWidzebra/depend:
You removed all dependencies. Is that right? You no longer depend on
Solaris? Zlib? Asn1? etc?
usr/src/pkgdefs/SUNWidzebra/prototype_i386:
usr/src/pkgdefs/SUNWidzebra/prototype_sparc:
It would be nice touch, if you also deliver symlinks to /usr/lib/64/
$ ls -l /usr/lib/64/libdlpi*
lrwxrwxrwx 1 root root 31 lis 12 2008 /usr/lib/64/libdlpi.so ->
../../../lib/amd64/libdlpi.so.1
lrwxrwxrwx 1 root root 31 lis 12 2008 /usr/lib/64/libdlpi.so.1
-> ../../../lib/amd64/libdlpi.so.1
Thank you!
--
Vlad
