Hi,
> Since I didn't get many comments earlier, I generated the webrev
> using the full list of files I've added/updated so those who hadn't
> reviewed it previously would have access to the rest of the files.
> As this doesn't seem to be what people were expecting, I regenerated
> webrevs (one full one, one incremental with latest changes only) but
> am running into problems getting them uploaded to cr.opensolaris.org.
> I'll let the alias know once I've managed to get these webrevs up.
Ah, it didn't occur to me that it's "incremental" webrev. That would be
awesome if our tools could handle both full and incremental one ...
>> usr/src/cmd/idzebra/Makefile.sfw:
>> I wonder, why theese two are enclosed in brackets
>> 103 + ($(RM) -r $(ROOTLIB64)/idzebra*/modules)
>> 104 + ($(MV) $(ROOTBIN)/idzebra-config-*
>> $(ROOTBIN)/idzebra-config)
>
> Mostly because I'm somewhat makefile illiterate and have cribbed
> from other packages. If the brackets are unnecessary here, I'll
> take them out.
Well, make runs new shell for each line it can find in the makefile. So
this won't work:
target:
cd somewhere
./configure ....
Because every line is executed via new shell. If you need them to
execute in one shell, you have to place it on one line:
target:
cd somewhere; ./configure
or
target:
cd somewhere; \
./configure
If you use
target:
( cd somewhere; ./configure )
It will launch shell, which will launch subshell which will run the
commands. It will work, but it's waste of resources.
Since I thought you modified just the two lines, I pointed just to them.
But as you created whole makefile, you will have to remove all
unnecessary ()'s :)
>> usr/src/pkgdefs/SUNWidzebra/depend:
>> You removed all dependencies. Is that right? You no longer depend on
>> Solaris? Zlib? Asn1? etc?
>
> I'm dependent on SUNWlibyaz. As libyaz has all the other dependencies
> in common, I was told I could remove them from idzebra's depend file
> as they're already taken care of.
I am not expert here either, but I think that you must have your
dependencies + the Solaris core dependencies. Let's see if others can
clear this bit for me too.
>> usr/src/pkgdefs/SUNWidzebra/prototype_i386:
>> usr/src/pkgdefs/SUNWidzebra/prototype_sparc:
>> It would be nice touch, if you also deliver symlinks to /usr/lib/64/
>>
>> $ ls -l /usr/lib/64/libdlpi*
>> lrwxrwxrwx 1 root root 31 lis 12 2008 /usr/lib/64/libdlpi.so
>> -> ../../../lib/amd64/libdlpi.so.1
>> lrwxrwxrwx 1 root root 31 lis 12 2008
>> /usr/lib/64/libdlpi.so.1 -> ../../../lib/amd64/libdlpi.so.1
>
> I'll be happy to add those.
Excellent. I'll review your new webrev tomorrow.
Thank you
--
Vlad
