Vladmir, First, thanks for taking the time to look over my webrev. I'll try to address your points below.
Vladimir Marek wrote: > usr/src/pkgdefs/SUNWidzebra/copyright: > That file does not seem to have any differences. Either there should > be something, or it should not be in the webrev. Since I didn't get many comments earlier, I generated the webrev using the full list of files I've added/updated so those who hadn't reviewed it previously would have access to the rest of the files. As this doesn't seem to be what people were expecting, I regenerated webrevs (one full one, one incremental with latest changes only) but am running into problems getting them uploaded to cr.opensolaris.org. I'll let the alias know once I've managed to get these webrevs up. > usr/src/cmd/Makefile: > usr/src/pkgdefs/Makefile: > You seem to be only adding perl510. Probably it's just unsynced > workspace. But again, if you are not adding anything here, Makefile > should not be in webrev. That's a 'change' picked up in my latest sync with the gate on Monday, as I generated an incremental webrev but still had all files I've touched in the list. If I can get my latest webrevs up this sort of stuff should disappear. > usr/src/cmd/idzebra/Makefile.sfw: > I wonder, why theese two are enclosed in brackets > 103 + ($(RM) -r $(ROOTLIB64)/idzebra*/modules) > 104 + ($(MV) $(ROOTBIN)/idzebra-config-* > $(ROOTBIN)/idzebra-config) Mostly because I'm somewhat makefile illiterate and have cribbed from other packages. If the brackets are unnecessary here, I'll take them out. > usr/src/pkgdefs/SUNWidzebra/depend: > You removed all dependencies. Is that right? You no longer depend on > Solaris? Zlib? Asn1? etc? I'm dependent on SUNWlibyaz. As libyaz has all the other dependencies in common, I was told I could remove them from idzebra's depend file as they're already taken care of. > usr/src/pkgdefs/SUNWidzebra/prototype_i386: > usr/src/pkgdefs/SUNWidzebra/prototype_sparc: > It would be nice touch, if you also deliver symlinks to /usr/lib/64/ > > $ ls -l /usr/lib/64/libdlpi* > lrwxrwxrwx 1 root root 31 lis 12 2008 /usr/lib/64/libdlpi.so > -> ../../../lib/amd64/libdlpi.so.1 > lrwxrwxrwx 1 root root 31 lis 12 2008 > /usr/lib/64/libdlpi.so.1 -> ../../../lib/amd64/libdlpi.so.1 I'll be happy to add those. Regards, Andre
