Hi Paul, I have done the changes. Please review the same at http://cr.opensolaris.org/~spoorthy/perl-crypt-cbc4/ > > 1. usr/src/Makefile > Doesn't look as though you have changed this so remove it > > 2. usr/src/Makefile > Move perl_crypt_cbc so that they are in alphabetically order > Done > 3. usr/src/lib/perl_crypt_cbc/METADATA > Add correct entry for BUGTRAQ > Bug category is not created. I have sent the request to create bug category under solaris/library > 4. usr/src/lib/perl_crypt_cbc/Makefile.sfw > + usr/src/lib/perl_crypt_cbc/install-sfw > + any other files > Remove extra space chars in the CDDL header lines, ie. .. > # ..... > becomes .. > # ..... > Done > 5. usr/src/lib/perl_crypt_cbc/Makefile.sfw > Why are you not using lines 28 & 29 ? ... > 28 #VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) > 29 #TARBALL = $(VER).tar.gz > 30 VER = Crypt-CBC-2.30 > 31 TARBALL = Crypt-CBC-2.30.tar.gz > Done > 6. usr/src/pkgdefs/SUNWperl-crypt-cbc/depend > Your Makefiles says you are using the default 'depend' file > so you can delete this file. But are you sure you have no > other dependencies that should be included? > I need this file. This package is dependent on the other package called SUNWperl-crypt-des. I am working on porting this package in parallel. > 7. usr/src/pkgdefs/SUNWperl-crypt-cbc/copyright > It might be better to wrap the 'long' lines in this file >
> 8. usr/src/pkgdefs/SUNWperl-crypt-cbc/pkginfo > Delete this file (from checked in) as its autogenerated > from pkginfo.tmpl > Done > 9. usr/src/pkgdefs/SUNWperl-crypt-cbc/pkginfo.tmpl > Add pkg version at the end of the DESC line, eg .. > DESC="................... (2.30)" > Added version of the package > The SCCS ident line doesn't look right (and check it in other > files) > > 10. usr/src/pkgdefs/SUNWperl-crypt-cbc/prototype_sparc > Line 46 says 'i386' ??? > Changed it
