On Thu, 2009-09-03 at 15:54 +0530, Spoorthy H.S wrote: > Hi Mark, > > After review of the ARC one pager, I have done modifications. So, you > can have a look at this new webrev > http://cr.opensolaris.org/~spoorthy/ws_cryptcbc1/
usr/src/Targetdirs:1465 No need to create the /usr/demo/crypt-cbc/t directory METDATA:9 You'll need to create a bugster category and update this line. usr/src/lib/perl_crypt_cbc/Makefile.sfw:32 Remove this line. CONFIGURE_OPTIONS isn't used usr/src/lib/perl_crypt_cbc/Makefile.sfw:35,38 Remove the brackets. No need for a sub-shell here. usr/src/lib/perl_crypt_cbc/Makefile.sfw:46 Remove this line - it looks like an autoconf variable. usr/src/lib/perl_crypt_cbc/Makefile.sfw:45,50 Remove the brackets. No need for a sub-shell here. usr/src/lib/perl_crypt_cbc/Makefile.sfw:48 Remove this line. make isn't used here. usr/src/lib/perl_crypt_cbc/Makefile.sfw:52-54 I think you can remove this rule entirely. The tarball will be unpacked via rules from the included makefiles. Change the line 44 to read: $(VER)/Makefile.PL: $(VER)/$(SFW_STAMP_UNPACKED) usr/src/lib/perl_crypt_cbc/install-sfw:44 Is this the top-level README from the tarball? If so I don't think it should be delivered into /usr/demo. usr/src/lib/perl_crypt_cbc/install-sfw:42 Makefile.PL shouldn't be delivered to /usr/demo usr/src/lib/perl_crypt_cbc/install-sfw:34 I don't see the need for the "eg" directory in /usr/demo. I think the example perl scripts can go straight into Crypt CBC dir in /usr/demo. usr/src/lib/perl_crypt_cbc/install-sfw:36 You set MANSCRIPT but it is never used. Where is the man page to be installed? usr/src/lib/perl_crypt_cbc/install-sfw:46-48 These perl scripts should be installed using the 'P' type not 'N'. usr/src/pkgdefs/SUNWperl-crypt-cbc/depend:52,53 This makes the package dependent on Perl 5.10 but you are delivering for 5.8 usr/src/pkgdefs/SUNWperl-crypt-cbc/pkginfo.tmpl:52-58 These commented-out lines should be removed. usr/src/pkgdefs/SUNWperl-crypt-cbc/prototype_com:63,64 These lines should probably be removed. Thanks, -M
