On Thu, 2009-09-03 at 17:07 +0530, Spoorthy H.S wrote: > > Mark Phalan wrote: > > usr/src/Targetdirs:1465 > > No need to create the /usr/demo/crypt-cbc/t directory > > > > METDATA:9 > > You'll need to create a bugster category and update this line. > > > > usr/src/lib/perl_crypt_cbc/Makefile.sfw:32 > > Remove this line. CONFIGURE_OPTIONS isn't used > > > > usr/src/lib/perl_crypt_cbc/Makefile.sfw:35,38 > > Remove the brackets. No need for a sub-shell here. > > > > usr/src/lib/perl_crypt_cbc/Makefile.sfw:46 > > Remove this line - it looks like an autoconf variable. > > > > usr/src/lib/perl_crypt_cbc/Makefile.sfw:45,50 > > Remove the brackets. No need for a sub-shell here. > > > > usr/src/lib/perl_crypt_cbc/Makefile.sfw:48 > > Remove this line. make isn't used here. > > > > usr/src/lib/perl_crypt_cbc/Makefile.sfw:52-54 > > I think you can remove this rule entirely. The tarball will be unpacked > > via rules from the included makefiles. Change the line 44 to read: > > $(VER)/Makefile.PL: $(VER)/$(SFW_STAMP_UNPACKED) > > > > > Done ... > > usr/src/lib/perl_crypt_cbc/install-sfw:44 > > Is this the top-level README from the tarball? If so I don't think it > > should be delivered into /usr/demo. > > > > > Yeah. This is from tar. I shouldn;t keep this ?
Is it useful for a user? If not then it shouldn't be delivered. From my quick glance it looked like it was more concerned with installing Crypt::CBC and didn't have anything useful for a user. > > usr/src/lib/perl_crypt_cbc/install-sfw:42 > > Makefile.PL shouldn't be delivered to /usr/demo > > > > > If not, where should it be delivered ?? Or it should not be delivered at > all ? As per the ARC case - not at all. > > usr/src/lib/perl_crypt_cbc/install-sfw:34 > > I don't see the need for the "eg" directory in /usr/demo. I think the > > example perl scripts can go straight into Crypt CBC dir in /usr/demo. > > > > > Created because it had README and Makefile.PL along with a directory > eg/*.pl examples. I don't think the README or Makefile.PL should be delivered there so these demo scripts can move back down. > > usr/src/lib/perl_crypt_cbc/install-sfw:36 > > You set MANSCRIPT but it is never used. Where is the man page to be > > installed? > > > > > Man page installed to perl5 directory as > usr/perl5/5.8.4/man/man3/Crypt::CBC.3 Where? install-sfw doesn't install the man page. > > usr/src/lib/perl_crypt_cbc/install-sfw:46-48 > > These perl scripts should be installed using the 'P' type not 'N'. > > > > > Done.. > > usr/src/pkgdefs/SUNWperl-crypt-cbc/depend:52,53 > > This makes the package dependent on Perl 5.10 but you are delivering for > > 5.8 > > > > > Its because, final deliverable is for 5.10. Please don't send things out for review until you think they are ready for integration - it just wastes people's time. At the moment it is inconcistent with some things using 5.8 and others using 5.10. It should be consistent. > And now the package > perl-5.10 is not done completely by responsible person. Its still in > testing process. Perl 5.10 is in SFW and was integrated with this putback (almost a month ago): From: John Sonnenschein <[email protected]> To: Mark.Phalan at Sun.COM Subject: Code Manager notification (putback-to) Date: Fri, 07 Aug 2009 11:10:13 -0700 (PDT) (20:10 CEST) Event: putback-to Parent workspace: /ws/sfwnv-gate (sfwnv:/ws/sfwnv-gate) Child workspace: /net/jade.sfbay/builds1/js228356/perl_ws (jade.sfbay:/builds1/js228356/perl_ws) User: js228356 Comment: PSARC/2009/315 Update Perl to version 5.10.x 6841312 would like to have perl 5.10 Files: update: usr/src/cmd/Makefile update: usr/src/pkgdefs/Makefile update: usr/src/tools/exception_list.check-deps create: usr/src/cmd/perl510/METADATA create: usr/src/cmd/perl510/Makefile.sfw create: usr/src/cmd/perl510/atinc.patch create: usr/src/cmd/perl510/config.sh.i386 create: usr/src/cmd/perl510/config.sh.sparc ... -M PS I added back sfwnv-discuss as it seems to have been dropped.
