Comments from my quick skip through ... Paul
Gayatri.Tripathi at Sun.COM wrote: > > Request a review of my code located at : > http://cr.opensolaris.org/~gtripthi/cheetah/ > > The cheetah url is : http://www.cheetahtemplate.org/ 1. usr/src/cmd/cheetah/METADATA Cosmetic: align the DESCRIPTION: string with the other lines 2. usr/src/cmd/Makefile Is this change correct - I would have expected you just to add your pkg 3. usr/src/pkgdefs/SUNWcheetah/copyright Is there a licence (text contents) you should be including here? 4. usr/src/pkgdefs/SUNWcheetah/depend Should this also include the core pkgs from the default depend? 5. usr/src/pkgdefs/SUNWcheetah/pkginfo.tmpl Add version number at end of the DESC= line, eg ... DESC=".......... (2.2.1)" 6. SCCS ident Are the SCCS ident lines correct - the dates seem at bit old? -- Paul Cunningham Software Engineer Tel:
