Gayatri, This looks okay to me except for the usr/src/pkgdefs/SUNWcheetah/depend ...
this I think should contain the core packages as in the default 'depend' http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/common_files/depend. And why does yours now contain this strange long list of pkgs, is it correct? Also, does the delivered man page, cheetah.3, contain the sunman-stability stuff ? Paul Gayatri.Tripathi at Sun.COM wrote: > > Thanks for the review comments. > > I did the corrections, please see the updated files at > http://cr.opensolaris.org/~gtripthi/cheetahws/ > > I did not change the copyright file as it is the same given in the > cheetah package. > > Thanks & Regards, > Gayatri > > > On 08/29/09 02:17, Jim Walker wrote: >> Gayatri.Tripathi at Sun.COM wrote: >>> Hi, >>> >>> Request a review of my code located at : >>> http://cr.opensolaris.org/~gtripthi/cheetah/ >>> >>> The cheetah url is : http://www.cheetahtemplate.org/ >> >> usr/src/Targetdirs >> - why python2.4 instead of python2.6? Isn't 2.4 going away? >> >> usr/src/cmd/Makefile >> - Something is very wrong here. This is a diff of Targetdirs? >> >> usr/src/cmd/cheetah/METADATA >> 10 OSR: 12630 >> - use OSR 9723. OSR 12630 is not approved for external use. >> since the license is the same, the version difference is not >> a problem. >> >> usr/src/cmd/cheetah/Makefile.sfw >> 26 #ident "@(#)Makefile.sfw 1.2 09/06/30 SMI" >> - add a space before the "ident" and do a "wx redelget" to >> get rid of extra deltas on all files. >> - This a new file and should be 1.1. >> >> How do you modify the man page(s) to include the stability >> block? Take a look at: usr/src/lib/logilab-common >> >> usr/src/pkgdefs/SUNWcheetah/depend >> - core packages should not be removed. >> >> usr/src/pkgdefs/SUNWcheetah/prototype_com >> - files and directories should be sorted alphabetically >> - where are the man page(s)? >> >> usr/src/pkgdefs/SUNWcheetah/prototype_i386 >> usr/src/pkgdefs/SUNWcheetah/prototype_sparc >> - change pylint to cheetah -- Paul Cunningham Software Engineer Tel:
