Hi Jim, Please see my inputs inline. My new files are at http://cr.opensolaris.org/~gtripthi/cheetahws/
On 09/01/09 02:56, Jim Walker wrote: > Gayatri.Tripathi at Sun.COM wrote: >> Hi Paul, Jim, >> >> Thanks for the review comments. >> >> I did the corrections, please see the updated files at >> http://cr.opensolaris.org/~gtripthi/cheetahws/ > > This new file should appear in the webrev: > cheetah.3.sunman > I am trying to do webrev -O -U but not able to see this file in webrev. Can you let me know what can be the problem. It exists in my sccs repository. > usr/src/pkgdefs/SUNWcheetah/prototype_com > - files and directories must be in alphabetic order > Sorted the list in alphabetic order > usr/src/pkgdefs/SUNWcheetah/depend > - run make check-deps to get exact pkg depend list > - your list is too long. you only need to include > direct dependencies not what your dependencies depend on > don't use the source juicer list. > - your list should begin with the default core > dependencies (see pylint depend file): > P SUNWcar Core Architecture, (Root) > P SUNWcakr Core Solaris Kernel Architecture (Root) > P SUNWkvm Core Architecture, (Kvm) > P SUNWcsr Core Solaris, (Root) > P SUNWckr Core Solaris Kernel (Root) > P SUNWcnetr Core Solaris Network Infrastructure (Root) > P SUNWcsu Core Solaris, (Usr) > P SUNWcsd Core Solaris Devices > P SUNWcsl Core Solaris Libraries > - then the cheetah centric dependencies > P SUNWPython26 The Python interpreter, libraries and utilities > ... > Changed the list of required packeges > Cheers, > Jim Thank, Gayatri
