Hi Laca, This basically looks okay to me, but I have a number of general comments that you might want to consider, see below ...
Paul Laszlo (Laca) Peter wrote: > http://cr.opensolaris.org/~laca/libxml2-2.7.6/ fixes the following > bugs: > > 6745178 update libxml2 to 2.7.1 (or later) > 6832483 Python libxml not available for 2.5, 2.6 > 6849500 libxslt need to be updated within opensolaris > > Updates libxml2 to the latest (2.7.6), removes upstream patches > and adds some new patches that fix bugs discovered since the > release of 2.7.6. "globals.patch" makes some private functions > public. These functions used to be public and are included in > the Solaris mapfile. The patch effectively reverses the change > that made them private. > > Also updates libxslt to the latest (1.1.26). > > In both modules, the Python bindings are built twice: for > Python 2.4 and for Python 2.6. The 2.6 bindings are in > new packages SUNWlxml-python26 and SUNWlxsl-python26. START 1. usr/src/lib/libxml2/Makefile.sfw & usr/src/lib/libxslt/Makefile.sfw Change so that the VAR= info is extracted from the METADATA file - see example at ... "http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/meld/Makefile.sfw"; Change throughout 'env ' to 'env - ' so they don't pick up random environment vars. Change ... ./configure --prefix=/usr to use the predefined --prefix= value from Makefile.master, ie. --prefix=$(CFGPREFIX) 2. usr/src/lib/libxml2/Makefile.sfw Combine lines 135 & 136 as .. -rm -rf $(VER) $(VER64) (and in libxslt/Makefile.sfw) 3. Various files At the top of files remove the extra '#' lines, ie ... change ... 1 # 2 # 3 # CDDL HEADER START 4 # to ... # # CDDL HEADER START # 4. usr/src/lib/libxml2/globals.patch Maybe the reason for these being made public again should be stated in the METADATA Comments: field ? 5. usr/src/lib/libxml2/install-libxml2 & usr/src/lib/libxml2/install-libxml2-64 & usr/src/lib/libxslt/install-libxslt & usr/src/lib/libxslt/install-libxslt Change so the VERS= info is passed in from the Makefile.sfw (there are various examples in the gate) - saves having to change it every version update. Change the following ... - '#!/bin/sh' to '#!/usr/bin/ksh93' - '. ${SRC}/tools/install.subr' to 'source ${SRC}/tools/install.subr' add ... set -o errexit see example in .. "http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/meld/install-sfw"; Don't install new files into /usr with the write-permission bit set. (and in the prototype_com file) 6. usr/src/pkgdefs/SUNWlxml-python/pkginfo.tmpl & usr/src/pkgdefs/SUNWlxml-python26/pkginfo.tmpl Change the DESC= line so the version is at the end of the line, as in ... "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/pkginfo.tmpl"; 7. usr/src/pkgdefs/SUNWlxsl-python26/depend & usr/src/pkgdefs/SUNWlxml-python26/depend Move the copyright lines to after the 'CDDL HEADER END' 8. usr/src/lib/libxslt/METADATA Should this include a valid OSR number? END -- Paul Cunningham Software Engineer
