Laca,

I did a quick skip through and this looks okay to me.

Paul

Laszlo (Laca) Peter wrote:
> 
> Thanks for the detailed review and sorry about the delay, I was
> working on another project.
> 
> I have made all suggested changes, except:
> 
>> 6. usr/src/pkgdefs/SUNWlxml-python/pkginfo.tmpl
>>      & usr/src/pkgdefs/SUNWlxml-python26/pkginfo.tmpl
>>     Change the DESC= line so the version is at the end of the
>>     line, as in ...
>> "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/pkginfo.tmpl";
> 
> These used to be in the libxml2/libxslt pkginfo files until the
> previous update, when I removed them at the reviewer's request :)
> 
> New webrev at http://cr.opensolaris.org/~laca/libxml2-2.7.6/
> 


>>
>> Laszlo (Laca) Peter wrote:
>>> http://cr.opensolaris.org/~laca/libxml2-2.7.6/ fixes the following
>>> bugs:
>>>
>>> 6745178 update libxml2 to 2.7.1 (or later)
>>> 6832483 Python libxml not available for 2.5, 2.6
>>> 6849500 libxslt need to be updated within opensolaris
>>>
>>> Updates libxml2 to the latest (2.7.6), removes upstream patches
>>> and adds some new patches that fix bugs discovered since the
>>> release of 2.7.6.  "globals.patch" makes some private functions
>>> public.  These functions used to be public and are included in
>>> the Solaris mapfile.  The patch effectively reverses the change
>>> that made them private.
>>>
>>> Also updates libxslt to the latest (1.1.26).
>>>
>>> In both modules, the Python bindings are built twice: for
>>> Python 2.4 and for Python 2.6.  The 2.6 bindings are in
>>> new packages SUNWlxml-python26 and SUNWlxsl-python26.


-- 
Paul Cunningham
Software Engineer

Reply via email to