Sriram, I took a quick look at this (mainly cosmetically), see comments below ...
Paul Sriram Natarajan wrote: > I would like to address following php bugs within build 128 > > 6877619 remove redundant PHP DTrace extension > ... cut ... > mod_php can't be used > 6893914 split 3rd party extensions into its own packages > > Web Rev URL: http://cr.opensolaris.org/~sn123202/b128.1/webrev/ 1. usr/src/pkgdefs/SUNWphp52u-*/copyright Should these have the Sun GPL disclaimer at the top for a PHP licence? 2. usr/src/pkgdefs/SUNWphp52u-*/depend Why do these have dependency on the root pkg for SUNWphp52r-mysql ? Are the dependencies right in all the new pkgs? 3. usr/src/pkgdefs/SUNWphp52u-*/pkginfo.tmpl You probably don't need the version number on the NAME= lines Might be better if the version number on the DESC= lines is at the end of the line in common with other pkgs, eg ... DESC=".................... (5.2)" PKG=, the package name is wrong in a number if not all of these? NAME= & DESC=, they all seem to refer to MySQL ? 4. usr/src/pkgdefs/SUNWphp52u-*/prototype_com & usr/src/pkgdefs/SUNWphp52u-*/prototype_i386 & usr/src/pkgdefs/SUNWphp52*/prototype_sparc Pkg name on comment line wrong ? I gave up at this point, and will let you fix this lot first. Hope that helps -- Paul Cunningham Jobless Software Engineer
