Sriram, Your webrev link below doesn't seem to work for me
Paul Sriram Natarajan wrote: > > > Paul Cunningham wrote: >> >> >> 1. usr/src/cmd/php5/METADATA >> Should the PACKAGES: line include all the new packages >> that you are creating ? >> > thanks for pointing it out. I have updated these now. >> 2. usr/src/pkgdefs/SUNWphp52u-*/copyright >> & usr/src/pkgdefs/SUNWphp52r-*/copyright >>>> Should these have the Sun GPL disclaimer at the top for >>>> a PHP licence? >> Should these 'copyright' files include this disclaimer? (the >> licence is not GPL) > Initially, when I was delivering PHP integration , our lawyers asked us > to include in them because we do link against some of the LGPL licenses > libraries. Since then, I have been carrying it . I guess, it doesn't > hurt as it only provides clarification. >> >> 3. usr/src/pkgdefs/SUNWphp52r-*/prototype_com >> Do any of the files installed by these 'root' >> packages need to be retained over a pkg install update, if >> so I think the 'f none ..' lines need changing to reflect >> that. >> > Yes, it does. each of these root packages deliver .ini files which will > need to be retained if modified while upgrading. >> 4. pkgdefs/Makefile >> Doesn't seem to be in this webrev (I think it was in the >> last one) ? >> > Good catch. I am surprised why 'wx' tool didn't include this file in my > previous webrev report. wx putback -n and wx pdiffs -u pkgdefs/Makefile > does show that this file was changed though. In any case, I have tried > again and now find this file in the latest webrev report. Please find > the latest webrev to capture the METADATA changes that you mentioned > earlier.. > > http://cr.opensolaris.org/~sn1233202/b128.3/webrev/ >> Everything else looks okay to me >> > thanks for taking time to look into this. > > - Sriram > > -- Paul Cunningham Software Engineer
