Sriram, More comments below from my very quick skip through ...
Paul Sriram Natarajan wrote: > > Thanks for your comments. Please find the updated webrev at this below > location > http://cr.opensolaris.org/~sn123202/b128.2/webrev > > Here are bugs that will be addressed with this putback: > > [sn123202 at zod]'pkgdefs'>wx > bugs > > > 6877619 remove redundant PHP DTrace extension > 6893914 split 3rd party extensions into its own packages > > Note: nightly builds and pbchk results didn't return any issues. ... cut .. >> Sriram Natarajan wrote: >>> I would like to address following php bugs within build 128 >>> >>> 6877619 remove redundant PHP DTrace extension >>> ... cut ... >>> 6893914 split 3rd party extensions into its own packages >>> Web Rev URL: http://cr.opensolaris.org/~sn123202/b128.1/webrev/ 1. usr/src/cmd/php5/METADATA Should the PACKAGES: line include all the new packages that you are creating ? 2. usr/src/pkgdefs/SUNWphp52u-*/copyright & usr/src/pkgdefs/SUNWphp52r-*/copyright >> Should these have the Sun GPL disclaimer at the top for >> a PHP licence? Should these 'copyright' files include this disclaimer? (the licence is not GPL) 3. usr/src/pkgdefs/SUNWphp52r-*/prototype_com Do any of the files installed by these 'root' packages need to be retained over a pkg install update, if so I think the 'f none ..' lines need changing to reflect that. 4. pkgdefs/Makefile Doesn't seem to be in this webrev (I think it was in the last one) ? Everything else looks okay to me -- Paul Cunningham Software Engineer
