On Sun, Mar 14, 2010 at 07:32:34PM -0500, Nicolas Williams wrote:
> On Sat, Mar 13, 2010 at 09:15:40AM +0100, Marcel Telka wrote:
> > On Fri, Mar 12, 2010 at 05:56:11PM -0600, Nicolas Williams wrote:
> > >  - Would it be better to patch configure.ac instead of configure?
> > 
> > When I would patch configure.ac the configure needs to be either patched 
> > too or
> > regenerated. Regeneration on the fly needs some extra tools like autoconf.
> > Patching of both configure.ac and configure would technically end in very
> > similar situation as I have now where I patched the configure only. During 
> > the
> > build nobody cares about the configure.ac content.
> 
> Huh?  We don't have autoconf installed on build servers?

We do. But additional complexity is not good if I can easily avoid it. :-)

> 
> > >    Can you please test that using white/light foreground color on
> > >    black/dark foreground color?
> > 
> > I tested both old mutt and the new one with different color settings of mutt
> > and terminal and in all cases the color output from both mutts was exactly 
> > the
> > same. The only difference were extra spaces with the old mutt.
> 
> Will you submit this patch upstream?

Already done http://dev.mutt.org/trac/ticket/3392



Thanks.

-- 
Marcel Telka
RPE, Systems

Reply via email to