Marcel Telka wrote:
> Hi all,
>
> I would like to ask you for code review of the following webrev for there CRs:
>
> 6784591 SUNWgnu-gettext does not include autopoint
> 6785384 SUNWgnu-gettext does not include autoconf m4 files
>
> The webrev is available at:
>
> http://cr.opensolaris.org/~aragorn/6785384-gettext/
Thanks for fixing the missing m4 issue - this has been hurting us in X for a
while, and I think hurts JDS too.
I can't claim to have done a complete review, but I have to wonder why you're
removing the docs in the install rule instead of shipping them in the package.
(Perhaps the html copies of the man pages are extraneous, but what about the
FAQ and other docs?)
I also note you're losing the non-exec stack protection mapfile, but that really
is something SFW should apply globally in it's build.
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
