On Wed, Mar 17, 2010 at 11:52:42PM -0700, Alan Coopersmith wrote: > Marcel Telka wrote: > > Hi all, > > > > I would like to ask you for code review of the following webrev for there > > CRs: > > > > 6784591 SUNWgnu-gettext does not include autopoint > > 6785384 SUNWgnu-gettext does not include autoconf m4 files > > > > The webrev is available at: > > > > http://cr.opensolaris.org/~aragorn/6785384-gettext/ > > Thanks for fixing the missing m4 issue - this has been hurting us in X for a > while, and I think hurts JDS too.
Yes. There are several affected projects. I hope, after the integration, the life will be easier for (at least) few people. > > I can't claim to have done a complete review, but I have to wonder why you're > removing the docs in the install rule instead of shipping them in the package. > (Perhaps the html copies of the man pages are extraneous, but what about the > FAQ and other docs?) The reason is simple. Now, the whole doc directory (plus the info file) is delivered in SUNWgnome-common-devel package with the exactly same path. So I decided, as an interim solution, to not include the doc in the SUNWgnu-gettext package to avoid potential conflict. I plan to file a CR against SUNWgnome-common-devel so the gettext doc is removed from that package. After the removal I'll start to deliver the doc into SUNWgnu-gettext. Would you recommend some better way how to have this achieved? > > I also note you're losing the non-exec stack protection mapfile, but that > really > is something SFW should apply globally in it's build. It is already applied globally. It is a standard part of the LDFLAGS and it is set in usr/src/cmd/Makefile.cmd. You can confirm it is still used in gettext build by looking into the build log, available internally at: /net/zod.sfbay/builds/mt198684/6785384-gettext/log/log.2010-03-18.00\:04/nightly.log (If there ois somebody without access to SWAN interrested to the log file I can post it to some public place. Just ask.) Thanks. -- Marcel Telka RPE, Systems
