On Thu, Mar 18, 2010 at 04:05:43PM +0000, Paul Cunningham wrote:
>
>
> Marcel Telka wrote:
> >
> >I would like to ask you for code review of the following webrev for there
> >CRs:
> >
> >6784591 SUNWgnu-gettext does not include autopoint
> >6785384 SUNWgnu-gettext does not include autoconf m4 files
> >
> >The webrev is available at:
> >
> >http://cr.opensolaris.org/~aragorn/6785384-gettext/
> >
> >Ahould you have any questions, please ask.
> >
>
> This looks okay to me also, but ..
Thanks, Paul.
>
> in the Makefile.sfw, does the 'make install' need protofix run on it
> after the files are installed into the proto area to correct the
> permissions?
There is no reason for that. I always force "make install" to do his job
properly[*][**]. I do not need protofix workarounds.
[*] This is the reason for the
CONFIGURE_OPTIONS += INSTALL_DATA='$${INSTALL} -m 444'
line in the Makefile.sfw.
[**] Or, using better words: to do his job as I need it to be done :-).
--
Marcel Telka
RPE, Systems
