The https://issues.apache.org/jira/browse/SHINDIG-257 bug has more commentary on this. Summary:
- it was broken for non-english locales - Santiago fixed that - it was still broken for some weird cases like parsing an expires header with a non-GMT timezone, followed by formatting a date. - I've attached a patch that switches to Joda that should fix that problem. I really hate SimpleDateTimeFormat. Nothing with that many weird corner cases can be called Simple. On Mon, May 12, 2008 at 10:30 AM, Kevin Brown <[EMAIL PROTECTED]> wrote: > I'm confused -- are you building HEAD or are you building at that revision? > I definitely can't reproduce any build errors against HEAD, but I haven't > tried that revision again specifically since it was committed. > > On Mon, May 12, 2008 at 3:21 AM, Santiago Gala <[EMAIL PROTECTED]> > wrote: > > > > > El dom, 11-05-2008 a las 13:36 -0400, Vincent Siveton escribió: > > > Hi Santiago, > > > > > > Yes I second. > > > Hope to see a zone and a CI soon :) > > > > I actually built a git branch with all commits since this one (except > > for the changeset at r654993) and it works with HEAD (actually my > > purpose doing this was to test that my last commit was not breaking the > > build at all). > > > > Waiting for the build to be restored, be it via the patch removed, the > > tests removed or fixed or the code paths fixed. I have no clue how > > things are interacting, but the patch in this issue are about > > SimpleDateFormat(s) and the tests failing are both dealing with the > > Expires: header (a DateFormat is of course needed for the Expires > > header). > > > > Regards > > Santiago > > > > > > > > Cheers, > > > > > > Vincent > > > > > > 2008/5/11, Santiago Gala <[EMAIL PROTECTED]>: > > > > I'm getting an error with failed tests, after "mvn clean; mvn". > > > > > > > > I used git bisect to find where the build started to fail and found > > that > > > > commit r654993 (Applying SHINDIG-257, contributed by Brian Eaton.) is > > > > the first failing. > > > > > > > > I'm not certain about the error or how to fix it, but it is something > > > > like: > > > > > > > > (...) > > > > Failed tests: > > > > > > > testCacheableForFutureExpires(org.apache.shindig.gadgets.BasicContentCacheTest) > > > > > > > testCacheableForExpiresWithWait(org.apache.shindig.gadgets.BasicContentCacheTest) > > > > Tests run: 252, Failures: 2, Errors: 0, Skipped: 0 > > > > > > > > Anybody else seeing this? > > > > > > > > Regards > > > > Santiago > > > > > > > > -- > > > > Santiago Gala > > > > http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/> > > > > > > > > > > -- > > Santiago Gala > > http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/> > > > > >
