Actually I committed the fix. There was a bug that skipped the Locale.US in the test, so after this patch, the fix in the Abstract Base class would make the test fail.
I've just committed a very simple fix that restores the build, broken from this review on for those of us with non US default locale ;-) After that Brian submitted a patch to switch from SimpleDateFormat to Joda Regards Santiago On Mon, May 12, 2008 at 7:35 PM, Dave Smith <[EMAIL PROTECTED]> wrote: > On Sun, May 11, 2008 at 9:32 AM, Santiago Gala <[EMAIL PROTECTED]> > wrote: > > > > I'm getting an error with failed tests, after "mvn clean; mvn". > > > > I used git bisect to find where the build started to fail and found that > > commit r654993 (Applying SHINDIG-257, contributed by Brian Eaton.) is > > the first failing. > > > > I'm not certain about the error or how to fix it, but it is something > > like: > > > > (...) > > Failed tests: > > > > > testCacheableForFutureExpires(org.apache.shindig.gadgets.BasicContentCacheTest) > > > > > testCacheableForExpiresWithWait(org.apache.shindig.gadgets.BasicContentCacheTest) > > Tests run: 252, Failures: 2, Errors: 0, Skipped: 0 > > > I saw this once, but it went away after either a "mvn clean" or manually > deleted BasicContentCacheTest.class. (I forget which, but kind of suspect > the latter.) > > > > > > > > Anybody else seeing this? > > > > Regards > > Santiago > > -- > > Santiago Gala > > > > http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/> > > > > >
