[ 
https://issues.apache.org/jira/browse/SHINDIG-268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Primmer updated SHINDIG-268:
----------------------------------

    Attachment: shindig-268_refactor_route_managment.patch

this patch is mostly a code cleanup, with no functionality change. I've moved 
the route enum to its own file and added some more info to it that will allow 
us to use it for other lookups. I've extended RouteManager to do an addRoute 
using this new enum. this allows the code in the provider to be shorter and 
more readable. 

I'd also attempted (but didn't succeed) to use guice to wire up all this stuff. 
the provider has a setTargetResolver method that would allow us to inject a 
RouteManager, however, you need to have the adapters initialized in order to 
call addRoute and wire up the route to adapter connection. I may revisit this 
later, but it's partway injectable now.

> Refactor Route managment in the provider
> ----------------------------------------
>
>                 Key: SHINDIG-268
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-268
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: David Primmer
>         Attachments: shindig-268_refactor_route_managment.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to