[
https://issues.apache.org/jira/browse/SHINDIG-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600365#action_12600365
]
David Primmer commented on SHINDIG-268:
---------------------------------------
After comments form James Snell, I think we should do away with the enum and
just create a subclassed RouteManager and set up our reasonable defaults. We
should replace the enum with a bunch of Route objects. There's no reason not to
use the existing route2ca map in that class. It should be easy for others to
add optional routes with the RouteManager and if not, we can add functionality
to Abdera via a patch.
If you'd like me to work up this idea in a patch I can do that, but the basic
idea, as I stated in the first comment is to actually bind the adapters to the
our subclassed RouteManager (don't know if we'll need to move setAdapters() or
if it can be done some other way), not the Provider, and then inject the
RouteManager object we create on both setTargetResolver and setTargetBuilder in
our SocialApiProvider. We already have SocialRouteManager checked in, why not
just re-use that?
> Refactor Route managment in the provider
> ----------------------------------------
>
> Key: SHINDIG-268
> URL: https://issues.apache.org/jira/browse/SHINDIG-268
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: David Primmer
> Attachments: exampleUsage.txt,
> shindig-268_refactor_route_managment.patch, useGuiceForRoutes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
