[
https://issues.apache.org/jira/browse/SHINDIG-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600333#action_12600333
]
David Primmer commented on SHINDIG-268:
---------------------------------------
comment on
exampleUsage.txt and useGuiceForRoutes.patch
I'm trying to figure out what your new adapter in exampleUsage.txt does and I
*think* it's some sort of rpc-oriented interface that the 'container' supports
that you'd like to have served by the abdera-based rest server. However, if I'm
puzzled about all these servers and what requests they handle, then I'm sure
others have no chance of figuring it out.
Some of the confusion results from us perpetuating the use of the word
'container' in too many different contexts. I have come to loath it. Your
example has a comment for a class called SampleContainerRouteProvider and has
an enum of SampleContainerUrls with a comment on an enum like this:
/**
* Lists all of the restful urls specific to the samplecontainer
*/
First, these urls do not appear to be RESTful at all. Second, I can never
figure out what this samplecontainer thing is and how it differs from a
container and shindig. Is it a legacy server that is going away? A legacy api
that is going away? Is it the thowaway social data part of shindig? A permanent
piece of functionality from another part of shindig that is now in social-api
land?
Maybe you could explain the inheritance used here? It doesn't seem useful to
have so much but I'm also not sure where shindig starts and ends. Your comment
about default and optional routes has something to do with this I'm sure.
Exactly how the inheritance works is somewhat constrained by abdera. However, I
don't think we agree on the 'fix abdera' thing so I'll comment on that next.
> Refactor Route managment in the provider
> ----------------------------------------
>
> Key: SHINDIG-268
> URL: https://issues.apache.org/jira/browse/SHINDIG-268
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: David Primmer
> Attachments: exampleUsage.txt,
> shindig-268_refactor_route_managment.patch, useGuiceForRoutes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
