On Wed, Apr 15, 2009 at 2:09 PM, Vincent Siveton <[email protected]>wrote:
> Hi Ian, > > 2009/4/15 Ian Boston <[email protected]>: > > I will try and get to the published artifacts stage, > > Where should the generated Maven documentation go ? > > Ian > > > > I spoke yesterday with Chris about the make-release.sh: this script > won't work on my ubuntu box :( Vincent I thought the fix was simple enough: replace the top line of the make-release.sh shell script that now reads: #!/bin/bash with wherever your bash is located (which you can easily discover by doing "which bash"), for instance: #!/usr/bin/bash Saying that "it won't work on ubuntu" is a slight over-exaggeration in my opinion :) (i did make a mental note I should probably use /bin/sh though since according to the FHS that should always be available, but i'll have to validate that the script works the same on sh first before i can switch that over) Using Maven will be more platform independent, but Chris underlines me > that the Maven assembly generates a different layout than the > make-release.sh. > So I modified the Maven files in r765148 to be align with this script. > > @Chris, could you review the generated and confirm that it is the wanted > layout? > I also commented that I think this is a "When you have a hammer, everything looks like a nail" type of solution. Most people who use PHP probably won't have a lot of java and maven knowledge, and are even likely not to even have a working java binary installed, let alone feeling like installing maven and downloading many Mb's of dependencies and we really shouldn't force that down people's throats, not if those tens of megabytes, and different-environment dependencies are just to solve something that can also be done with 20 lines of shell script. That just sounds like a solution looking for a problem :) Keep in mind that this script could be used to create a release-type-layout of the directory structure and configuration files by anyone who uses php-shindig, so the usage of it is far wider then just once to generate a release tarbal, as such the whole java / mvn dep could only be worth it from a php perspective if it offered significant benefits over shell script (or even php based) one..
