OK, I've picked up on this file as it is easier for me to query/make
suggestions.
What do you install in the "USR" directory (you don't have this in your
announcement)? From what I can see (and I am looking at the Fedora-centric rc
file as I am not that familiar with other distros), you don't have anything
installed in this directory, but use it as a base to others, in which case you
don't actually need this at all.
Using directories only makes sense if you use them to install files in it, not
employ them as pointers to some other directory - it is much more complicated
that way, keep it simple.
> LIBEXECDIR (Req'd) -- Directory where product executables are
> installed. Normally /usr/share or
> /usr/libexec.
Do you actually need this? System executables normally go to /sbin or /usr/sbin.
> SYSCONFFILE (Optional)
> -- Name of the file to be installed in the
> SYSCONFIGDIR. The installed name of the file
> will always be the product name (shorewall,
> shorewall-lite, etc.)
This is defined as "SYSCONFFILE=sysconfig" in the Fedora rc. I agree with the
above though - this should be the name of the product. I haven't looked much in
install.sh/deinstall.sh - just skimmed over the main shorewall install.sh file
and picked up on this:
#
# Load packager's settings if any
#
[ -f ../shorewall-pkg.config ] && . ../shorewall-pkg.config
#![...]
if [ -n "${DESTDIR}" -a -f ../shorewall-pkg.config ]; then
. ../shorewall-pkg.config || exit 1
#!
#! So, shorewall-pkg.config is sourced twice, if it exists. Why?
#!
file = ../shorewall-pkg.config
elif [ -f ~/.shorewallrc ]; then
#! Why do you reference ~/.shorewallrc and sourcing it if it exists? For what
purpose?
. ~/.shorewallrc || exit 1
file=~/.shorewallrc
else
fatal_error "No configuration file specified and ~/.shorewallrc not
found"
fi
It is good that you thought of removing (older) shorewall installations by
using absolute paths. On a separate note - I just realised that for some reason
I have "/var/lib/shorewallundo_rfc1918_routing" as well as
"/var/lib/shorewall/undo_rfc1918_routing" - I am still on 4.5.1.
I''l have a more thorough look tomorrow!
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel
