> That can't be right! The 'arp' binary isn't going to be in the script's
> current working directory.

I rewrote the diff using the 'qt mywhich' combo I've seen peppered
throughout 'lib.cli':


diff --git a/lib.cli b/lib.cli
index 68d9177..d695889 100644
--- a/lib.cli
+++ b/lib.cli
@@ -1503,7 +1503,11 @@ do_dump_command() {

     if [ $g_family -eq 4 ]; then
     heading "ARP"
-    arp -na
+    if qt mywhich arp; then
+        arp -na
+    else
+        ip -4 neigh ls
+    fi
     else
     heading "Neighbors"
     ip -6 neigh ls
@@ -1525,12 +1529,17 @@ do_dump_command() {

     echo

-    if qt netstat -4; then
-    netstat -${g_family}tunap
+    if qt mywhich -v netstat; then
+        if qt netstat -4; then
+             netstat -${g_family}tunap
+        else
+             netstat -tunap
+        fi
     else
-    netstat -tunap
+        ss -${g_family}tunap
     fi

+
     if [ -n "$TC_ENABLED" ]; then
     heading "Traffic Control"
     show_tc


However, seeing as how iproute is a dependency for Shorewall, would it
make more sense instead to outright replace instances of 'arp' and
'netsta't in the 'lib.cli' sections above with their iproute
equivalent 'ip -4 neigh' and 'ss'?

Best regards,
-Martin

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to