On Wed, 2018-02-28 at 08:51 -0800, Tom Eastep wrote:
> 
> There are quite a few, but they are only an issue for people who have
> to
> rely on the obscure 'lock' utility.

It's from busybox, FWIW.

> The rest just get a 'stale lock file
> removed' message the next time that they run shorewall[6][-lite]. 

Sure, but really, code should not be written to depend on the staleness
of locks being able to be determined.  Any code that takes out a lock
should release it when it's done.  I realize I am preaching to the
choir, yes.  :-)

So, to that end, when I use something like lock in a shell script I do
it like this:

lock /tmp/foo
trap 'lock -u /tmp/foo' EXIT

so that I *know* the lock will be released on every/any code path to
script exit.

Not sure how feasible that is for you to do even with mutex_on() being
shell script but just thought I would share.

> I'll
> try to come up with a fix against 5.1.12...

Awesome.  I wonder how many other issues that will resolve.

Cheers,
b.

Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Shorewall-users mailing list
Shorewall-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shorewall-users

Reply via email to