Hi Ole,

On Sun, Nov 29, 2009 at 02:07:16PM +0100, Ole Carlsen wrote:
> Here should be the latest .po and .desktop files for SHR in Danish from  
> my hand.

thanks a lot. A few comments:

You are a Windows guy? It's uncommon to compress with 7p and I had to
install it first. Please use ordinary tar.gz. Much better would be sending
patches as I did as this ensures that no other people work is overwritten.

You destroyed the encoding of some *.desktop files, they should be UTF-8
encoded not latin1 or even a mixture of latin1 and UTF-8. I fixed it.
I also reordered entries alphabetically.

PO files have by default some lines which contain placeholders which have to
be edited. You also didn't replicated spaces after colons (:). I know that some
languages could not require this but Danish probably not, right? (Do you
prefer: "current power:100%" or "current power: 100%"?).

Don't worry about thee issue, they are very minor but we want to provide the
best work possible, right?

I attached a patch against your files, please check carefully. This patch
contains also German entries for *.desktop files :-))

Thanks for your work, please continue (and report all issues you find),
Jens

Attachment: da.diff.gz
Description: Binary data

_______________________________________________
Shr-devel mailing list
[email protected]
http://lists.shr-project.org/mailman/listinfo/shr-devel

Reply via email to