ok,

this is a plausible explanation for the observed bahviour.

i have to admit that i was not thinking of non-gcc compilers when i used
"__attribute__((packed))" in that code-base. does you compiler silently
ignore them or is there a warning?

as it is non-standard i tend to rewrite affected code sections such that
they don't need this packed attribute (or similar).

acq_packet & transfer_packet structs will probably have to go away as
they are not useful without strict packing. (acq_packet needs to be
24bit in size...)

i will prepare a branch from libsigrok master to implement this. i will
let you know when its finished -- would be nice if you could then test
it with your compiler & OS.

...aside from that: i found two other uses of
__attribute__(([__]packed[__])) in libsigrok
src/hardware/lecroy-xstream/protocol.c.

what is the opinion on those uses? should those be changed as well? (in
a different pull request)


On 10/28/20 3:15 PM, Helge Kruse wrote:
This __packed__ attribute is not honored in the
MXE compiler. Fill bytes are inserted.

Should I send the details here in the list or should I open an issue in the
tracker?



_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to