"zpool create" is a part of upstream illumos with history going back to
OpenSolaris. Too much code already exists assumes that it silently does
what you told it to do. Changing it to be interactive would break that
existing code.
Less confusing warnings in the SmartOS installer is doable.
-Nahum
On 12/08/2015 04:45 PM, Avi Deitcher wrote:
Yes, it did... but only on the disks/partitions that I chose, which is
what I was after.
Essentially, I wanted to be sure that when I went back into the guided
installation that it would not destroy anything other than what I told
it to do / already did. And it does.
Actually, I think the right place to do that is at "zpool create".
On Tue, Dec 8, 2015 at 11:43 PM, Nahum Shalman
<[email protected] <mailto:[email protected]>> wrote:
On 12/8/15 13:34 , Avi Deitcher wrote:
So it looks like it does the right thing. But, yes, the
clear "we will wipe
these disks/partitions ____ " would be better.
Avi,
At the point when you ran "zpool create" *you* already wiped
whatever disks/partitions you chose to use.
I noticed a bunch of cruft in the functions that do the pool
creation that could use some cleanup.
With a bit of work we could probably suppress that warning if you
did manual pool creation.
Perhaps when we drop you to a shell to do manual creation we
should warn you *then* that zpool creation is a destructive action.
On 12/08/2015 04:38 PM, Robert Mustacchi wrote:
Feel free to file an RFE at
github.com/joyent/smartos-live/issues
<http://github.com/joyent/smartos-live/issues> for
that, we can certainly improve that.
+1
-Nahum
--
Avi Deitcher
[email protected] <mailto:[email protected]>
Follow me http://twitter.com/avideitcher
Read me http://blog.atomicinc.com
*smartos-discuss* | Archives
<https://www.listbox.com/member/archive/184463/=now>
<https://www.listbox.com/member/archive/rss/184463/22280019-340ab187>
| Modify
<https://www.listbox.com/member/?&;>
Your Subscription [Powered by Listbox] <http://www.listbox.com>
-------------------------------------------
smartos-discuss
Archives: https://www.listbox.com/member/archive/184463/=now
RSS Feed: https://www.listbox.com/member/archive/rss/184463/25769125-55cfbc00
Modify Your Subscription:
https://www.listbox.com/member/?member_id=25769125&id_secret=25769125-7688e9fb
Powered by Listbox: http://www.listbox.com
