Bhupesh SHARMA wrote: >> Bhupesh SHARMA wrote: >>> Please ignore the patch 2/4 Bosch CCAN driver sent earlier. >>> This resend contains the correct handling of BRP extension register. >> please remove the LINUX_VERSION_CODE, cleanup your patch for net-next- >> 2.6. > > I am in parallel preparing the patch against david miller's 2.6.35 and I will > try > to get it pushed in the netdev-next mailing list in the coming days. However, > I wished > to get some review comments from this list before submitting the same, mainly > because the > reference of this driver is the old bosch CCAN driver present in the SVN tree. > > That is why I added the LINUX_VERSION_CODE stuff.
I personally don't care about the svn (for drivers). net-next-2.6 is the reference. IMHO writing good kernel code is hard enough and adding ifdefs for older Kernels doesn't make it easier. It's not maintain- nor testable. If someone needs this driver for legacy kernels he/she can add the appropriate ifdefs and test it with that old kernel and get the driver into the svn. just my 2 cent, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
