> -----Original Message----- > From: Marc Kleine-Budde [mailto:[email protected]] > Sent: Tuesday, August 31, 2010 4:12 PM > To: Bhupesh SHARMA > Cc: Wolfgang Grandegger; [email protected] > Subject: Re: [RFC PATCH 2/4 RESEND] Bosch CCAN driver > > Bhupesh SHARMA wrote: > > [...] > > >>> +enum bosch_ccan_operating_mode { > >>> + CCAN_NORMAL_MODE = 0, > >>> + CCAN_BASIC_MODE, > >>> + CCAN_LOOPBACK_MODE, > >>> + CCAN_LOOPBACK_WITH_SILENT_MODE, > >>> + CCAN_SILENT_MODE > >>> +}; > >> I do not see a need for another enumeration o the type. We already > >> have the CAN_CTRLMODE_*. > > > > Yes. But I don't see CAN_CTRLMODE_* capturing all the operating mode > types supported by Bosch CCAN. > > which are missing?
I guess CCAN_BASIC_MODE and CCAN_LOOPBACK_WITH_SILENT_MODE are missing. Or am I missing something here. Regards, Bhupesh _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
