[ 
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466277
 ] 

Ryan McKinley commented on SOLR-104:
------------------------------------


I just thought of something that will make Hoss' blod curl!  I KNOW it
is a bad idea for things within solr-core, but it would be the
cleanest/cheapest way to expose the unknown things a potential
RequestHandler would want from the HttpServletRequest without changing
the existing API.  It goes like this:

  SolrRequest solrReq = (build the solr request)
  solrReq.getContent().put( "HttpServletRequest", req );

It would never be used by anything in core.

The alternative I see is to give each handler some mechanism to tell
the RequestBuilder what attributes it needs set, then have the
RequestBuilder put those attributes in the context or solr params.  In
my opinion, that is a lot of overhead to do stuff that clearly falls
outside of what solr-core should be doing.

ryan


> Update Plugins
> --------------
>
>                 Key: SOLR-104
>                 URL: https://issues.apache.org/jira/browse/SOLR-104
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 1.2
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: commons-fileupload-20070107.jar, commons-io-1.2.jar, 
> DispatchFilter.patch, DispatchFilter.patch, DispatchFilter.patch, 
> HandlerRefactoring-DRAFT-SRC.zip, HandlerRefactoring-DRAFT-SRC.zip, 
> HandlerRefactoring.DRAFT.patch, HandlerRefactoring.DRAFT.patch, 
> HandlerRefactoring.DRAFT.zip
>
>
> The plugin framework should work for 'update' actions in addition to 'search' 
> actions.
> For more discussion on this, see:
> http://www.nabble.com/Re%3A-Handling-disparate-data-sources-in-Solr-tf2918621.html#a8305828

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to