On 1/25/07, Ryan McKinley <[EMAIL PROTECTED]> wrote:
>
> On Jan 24, 2007, at 6:53 PM, Ryan McKinley wrote:
> > new SolrPing().process( server );
>
> doesn't
>
> server.ping();
>
> look cleaner?
>
I can't argue with you there!
I may be taking Hoss's point #4 on
https://issues.apache.org/jira/browse/SOLR-20#action_12464641 too
seriously. My revised version is designed totally around Requests
processing a handler's response. The server does not even know what
handlers it may be running - it is just the transport layer between
the request and the response.
But that may be too big of an abstraction for the simple use case.
server.ping()
server.add( documents );
server.delete( id );
server.select( options );
...
are obviously cleaner.
One form doesn't preclude the other either.... you can have both.
For more complex or custom request handlers, keeping the logic (and
library dependencies) out of the server seems like a good idea.
-Yonik
