[ https://issues.apache.org/jira/browse/SOLR-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-204: ------------------------------- Attachment: SOLR-204-HandleSelect.patch this removes the "handle-select" init param from web.xml and adds: <requestDispatcher handleSelect="true" /> to solrconfig.xml The one thing I would maybe change is to make the config more of a tree then a list, maybe we should have: <requestDispatcher handleSelect="true" > <requestParsers enableRemoteStreaming="false" multipartUploadLimitInKB="2048" /> </requestDispatcher> rather then: <requestDispatcher handleSelect="true" /> <requestParsers enableRemoteStreaming="false" multipartUploadLimitInKB="2048" /> This would change a configuration that has been added since 1.1 - - - - - - This patch also cleans up reading enableRemoteStreaming and multipartUploadLimitInKB, when i wrote it i did not know about the much cleaner: this.enableRemoteStreams = SolrConfig.config.getBool( "requestParsers/@enableRemoteStreaming", false ); > Let solrconfig.xml configure the SolrDispatchFilter to handle /select > --------------------------------------------------------------------- > > Key: SOLR-204 > URL: https://issues.apache.org/jira/browse/SOLR-204 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > Attachments: SOLR-204-HandleSelect.patch > > > The major reason to make everythign use the SolrDispatchFilter is that we > would have consistent error handling. Currently, > SolrServlet spits back errors using: > PrintWriter writer = response.getWriter(); > writer.write(msg); > and the SolrDispatchFilter spits them back using: > res.sendError( code, ex.getMessage() ); > Using "sendError" lets the servlet container format the code so it shows up > ok in a browser. Without it, you may have to view source to see the error. > Aditionaly, SolrDispatchFilter is more decerning about including stack trace. > It only includes a stack trace of 500 or an unknown response code. > Eventually, the error should probably be formatted in the requested format - > SOLR-141. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.