[ https://issues.apache.org/jira/browse/SOLR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560234#action_12560234 ]
Ryan McKinley commented on SOLR-350: ------------------------------------ Hi Henri- We're getting there.... but I had trouble applying this patch, can you post a new one with a few changes? 1. can you change your editor settings to use two spaces rather then tabs? In general, solr code should have two spaces rather then tabs or 4 spaces. 2. To avoid confusion with o.a.s.request.XMLWriter, can we call XmlWriter something else? XmlWriterHelper? XmlWriterUtils? 3. Can we make XmlWriter a package protected class in o.a.s.core? This way we don't have to make it part of the public API. If there is a need for it later, we can easily move it. Also, if it can be replaced with an off the shelf library, we can do that later without mucking anyone up. Thanks for your work and patience with this! > Manage Multiple SolrCores > ------------------------- > > Key: SOLR-350 > URL: https://issues.apache.org/jira/browse/SOLR-350 > Project: Solr > Issue Type: Improvement > Affects Versions: 1.3 > Reporter: Ryan McKinley > Attachments: SOLR-350-MultiCore.patch, SOLR-350-MultiCore.patch, > SOLR-350-MultiCore.patch, SOLR-350-Naming.patch, SOLR-350-Naming.patch, > solr-350.patch, solr-350.patch, solr-350.patch, solr-350.patch, > solr-350.patch, solr-350.patch > > > In SOLR-215, we enabled support for more then one SolrCore - but there is no > way to use them yet. > We need to make some interface to manage, register, modify avaliable SolrCores -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.