[ https://issues.apache.org/jira/browse/SOLR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562835#action_12562835 ]
Hoss Man commented on SOLR-350: ------------------------------- Actually, one more unrelated comment... bq. Looking good. I took your patch and removed all the 'default' stuff to make it in line with Hoss' observations in: ...i know i suggested moving anything related to the entire solr server into multicore.xml, but i've been looking at SolrDispatchFilter lately because of SOLR-127 and i'm starting to wonder if the <requestDispatcher/> config options really need to be webapp wide. They are (currently) only used to construct a protected instance of SolrRequestParsers in SolrDispatchFilter.init, but that SolrRequestParsers is only needed in the doFilter method once we've already figured out what core we're using ... it's a fairly light weight class, so why not construct a new one in each call to doFilter (after we've determined the correct core) and leave those options core specific? (not to mention the HTTP caching options SOLR-127 is probably going to add to <requestDispatcher/>) ... And while i'm thinking about it ... what does abortOnConfigurationError=true mean in a multicore world when someone attempts to dynamicly load a core with a config error? Currently SolrDispatchFilter only looks at that setting on init ... is MultiCore goung to start checking it after each LOAD core action? will it cause the whole server to stop accepting requests or just do something special for that one core? > Manage Multiple SolrCores > ------------------------- > > Key: SOLR-350 > URL: https://issues.apache.org/jira/browse/SOLR-350 > Project: Solr > Issue Type: Improvement > Affects Versions: 1.3 > Reporter: Ryan McKinley > Attachments: SOLR-350-MultiCore.patch, SOLR-350-MultiCore.patch, > SOLR-350-MultiCore.patch, SOLR-350-Naming.patch, SOLR-350-Naming.patch, > solr-350.patch, solr-350.patch, solr-350.patch, solr-350.patch, > solr-350.patch, solr-350.patch, solr-350.patch, solr-350.patch > > > In SOLR-215, we enabled support for more then one SolrCore - but there is no > way to use them yet. > We need to make some interface to manage, register, modify avaliable SolrCores -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.