[ 
https://issues.apache.org/jira/browse/SOLR-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605306#action_12605306
 ] 

Yonik Seeley commented on SOLR-486:
-----------------------------------

Thanks Noble, this looks pretty good.

I had previously considered caching strings via some kind of sliding window... 
keep track of the last 100 or so string values written under some certain 
length, and then if you see a string again in that window, write a reference 
(an index that says how many values ago it was seen).

For Solr responses in general, it seems like the main duplication will be in 
field names (which you have taken care of).  The only other duplication I can 
think of would be the "id" field values (used as a key in other maps such as 
highlighting), and any duplication that is custom to the collection (such as 
string values for a type field, etc).

Thoughts?  I'd be happy to commit this version, or give you time to try out an 
alternative if you think it might be worth it (but I don't currently have time 
myself to implement the alternative).

> Support binary formats for QueryresponseWriter
> ----------------------------------------------
>
>                 Key: SOLR-486
>                 URL: https://issues.apache.org/jira/browse/SOLR-486
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java, search
>            Reporter: Noble Paul
>            Assignee: Yonik Seeley
>             Fix For: 1.3
>
>         Attachments: SOLR-486.patch, solr-486.patch, SOLR-486.patch, 
> SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, 
> SOLR-486.patch, SOLR-486.patch, SOLR-486.patch
>
>
> QueryResponse writer only allows text data to be written.
> So it is not possible to implement a binary protocol . Create another 
> interface which has a method 
> write(OutputStream os, SolrQueryRequest request, SolrQueryResponse response)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to