[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yonik Seeley updated SOLR-647:
------------------------------
Attachment: solr-647.patch
Here's an updated patch:
- cores is a Map<String,SolrCore>
- no prohibition of adding a SolrCore to the CoreContainer multiple times (to
be able to access it from multiple URLs, for back compatible migration for
example)
I was going to remove the SolrCore name altogether.... but things like JMX and
logging use it.
That's a weakness in both the way multicore worked (core swap wouldn't swap
JMX) and the current patch (core name is independent of how it's mapped via
CoreContainer).
One resolution would be to have a callback on SolrCore whenever it's name is
changed, so JMX and logging strings could be appropriately adjusted.
> Do SolrCore.close() in a refcounted way
> ---------------------------------------
>
> Key: SOLR-647
> URL: https://issues.apache.org/jira/browse/SOLR-647
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Noble Paul
> Assignee: Yonik Seeley
> Fix For: 1.3
>
> Attachments: refcount_example.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, solr-647.patch, solr-647.patch,
> SOLR-647.patch, SOLR-647.patch
>
>
> The method _SolrCore.close()_ directly closes the core . It can cause
> Exceptions for in-flight requests. The _close()_ method should just do a
> decrement on refcount and the actual close must happen when the last request
> being processed by that core instance is completed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
