[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yonik Seeley updated SOLR-647:
------------------------------
Attachment: solr-647.patch
Here's a slight update:
- removes the SolrCore finalizer to prevent too many closes exception (we could
do a refcount check too)
- calls SolrCore.setName() when a core is added or renamed in the CoreContainer
(it was just too wierd to do a core swap and not have the names change). This
does not affect JMX.
I was going to remove the SolrCore name altogether.... but things like JMX and
logging use it.
bq. Can we remove it and always access the name via the CoreDescriptor? Having
a name on the core made sense before we added the descriptor...
If we did want to change JMX or other things on a name change, it seems like
the call needs to be on the SolrCore. Currently this does change the logging
string too (probably good for avoiding confusion on a core swap)
Unless there are objections, I think this is close enough to commit soon and
then propose smaller patches off of trunk.
> Do SolrCore.close() in a refcounted way
> ---------------------------------------
>
> Key: SOLR-647
> URL: https://issues.apache.org/jira/browse/SOLR-647
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Noble Paul
> Assignee: Yonik Seeley
> Fix For: 1.3
>
> Attachments: refcount_example.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, SOLR-647.patch, SOLR-647.patch
>
>
> The method _SolrCore.close()_ directly closes the core . It can cause
> Exceptions for in-flight requests. The _close()_ method should just do a
> decrement on refcount and the actual close must happen when the last request
> being processed by that core instance is completed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
