[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623204#action_12623204
]
henrib edited comment on SOLR-647 at 8/17/08 9:34 AM:
-------------------------------------------------------------
Small err that would affect reload() in CoreContainer.register, ~line 261, it
seems this should be:
{code}
log.info( "replacing core: "+name );
if (!returnPrev) {
old.close(); // not core.close()
}
{code}
Harmless, the "alias" attribute feature is folded into "name" so:
{code}
String aliasesStr = DOMUtil.getAttr(node, "aliases", null);
{code}
can go.
was (Author: henrib):
Small err that would affect reload() in CoreContainer.register, ~line 261, it
seems this should be:
{code}
log.info( "replacing core: "+name );
if (!returnPrev) {
old.close(); // not core.close()
}
{code}
> Do SolrCore.close() in a refcounted way
> ---------------------------------------
>
> Key: SOLR-647
> URL: https://issues.apache.org/jira/browse/SOLR-647
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Noble Paul
> Assignee: Yonik Seeley
> Fix For: 1.3
>
> Attachments: refcount_example.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, SOLR-647.patch, SOLR-647.patch
>
>
> The method _SolrCore.close()_ directly closes the core . It can cause
> Exceptions for in-flight requests. The _close()_ method should just do a
> decrement on refcount and the actual close must happen when the last request
> being processed by that core instance is completed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
