[ 
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625032#action_12625032
 ] 

Noble Paul commented on SOLR-716:
---------------------------------

bq.It would seem preferable & possible to only store the properties (versus the 
CoreDescriptor) in the SolrResourceLoader; this is the only piece needed for 
evaluation.
CoreDescriptor can be easily obtained from SolrCore anyway and SolrCore is 
available to every single class in Solr . SolrResourceLoader is our own class 
and it does not expose the object (it is private and there is no getter). This 
enables the resourceloader to get access to any other property from 
CodeDescriptor (in future) if needed . 

bq.users cannot specify a variable inside solr.xml 

Is it very useful ? considering that it can only substitute system properties?

> Support properties in configuration files
> -----------------------------------------
>
>                 Key: SOLR-716
>                 URL: https://issues.apache.org/jira/browse/SOLR-716
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 1.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.3
>
>         Attachments: SOLR-716.patch, SOLR-716.patch
>
>
> Initially suggested by Hoss at 
> https://issues.apache.org/jira/browse/SOLR-350?focusedCommentId=12562834#action_12562834
>  and taken forward by Henri in SOLR-646
> # Allows users to define global as well as core-specific properties in 
> solr.xml which can be used in solrconfig.xml and schema.xml
> {code:xml}
> <solr persistent="false">
>   <property name="var" value="value" />
>   <cores adminPath="/admin/cores">
>     <core name="core0" instanceDir="core0">
>       <property name="var" value="value" />
>     </core>
>     <core name="core1" instanceDir="core1" />
>   </cores>
> </solr>
> {code}
> # The following core-specific properties will be added automatically:
> ** solr.core.instanceDir
> ** solr.core.name
> ** solr.core.configName
> ** solr.core.schemaName
> # The variable substitution will be done in this fall-back order -- 
> core-specific, implicit, global, system properties.
> # The properties defined in solr.xml should also be persisted back as is 
> (without evaluation).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to