[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625033#action_12625033
]
Shalin Shekhar Mangar commented on SOLR-716:
--------------------------------------------
bq. You could do a second evaluation pass to expand the property values (if
they are property expressions) created for the CoreContainer and for each
CoreDescriptor.
If you were though, you'd need to keep the property expression map & the
property value map separated.
We can do that but that will require modifying the Config constructor to pass
in a boolean parameter "substituteProperties". If set to false, Config should
not try to substitute properties on the given node. When creating the Config
object for solr.xml itself, we don't know the properties because we haven't got
that point yet so we must suppress substitution. Later when we have read the
global properties and we start reading the "core" node, we can substitute
global+system properties on the "core" sub-tree. We can do that but I'm not
sure if that's necessary. Is it very useful?
> Support properties in configuration files
> -----------------------------------------
>
> Key: SOLR-716
> URL: https://issues.apache.org/jira/browse/SOLR-716
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.3
>
> Attachments: SOLR-716.patch, SOLR-716.patch
>
>
> Initially suggested by Hoss at
> https://issues.apache.org/jira/browse/SOLR-350?focusedCommentId=12562834#action_12562834
> and taken forward by Henri in SOLR-646
> # Allows users to define global as well as core-specific properties in
> solr.xml which can be used in solrconfig.xml and schema.xml
> {code:xml}
> <solr persistent="false">
> <property name="var" value="value" />
> <cores adminPath="/admin/cores">
> <core name="core0" instanceDir="core0">
> <property name="var" value="value" />
> </core>
> <core name="core1" instanceDir="core1" />
> </cores>
> </solr>
> {code}
> # The following core-specific properties will be added automatically:
> ** solr.core.instanceDir
> ** solr.core.name
> ** solr.core.configName
> ** solr.core.schemaName
> # The variable substitution will be done in this fall-back order --
> core-specific, implicit, global, system properties.
> # The properties defined in solr.xml should also be persisted back as is
> (without evaluation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
